GitLab

Signed-off-by: Florian Pritz <bluewind@xinu.at>

Signed-off-by: Florian Pritz <bluewind@xinu.at>

We are not only interested in checking if a method exists here, but
really also if it can be called (e.g. if it is public). Private methods
should not be considered as potential API endpoints. Before this,
private methods could be called, leading to a 500 error due to a call to
the private method.
Signed-off-by: Florian Pritz <bluewind@xinu.at>

This parameter controls the generated id for files (file/upload) and
multipastes (file/create_multipaste).
The post parameter has to be a positive integer value >= 2.

Changes by Florian Pritz:

 - minor style and typo fixes
 - NEWS entry
 - check expected error reply content in tests
Signed-off-by: Florian Pritz <bluewind@xinu.at>

Filebin unconditionally expects a 'python' command to be in path that is
compatible with the installed pygments library. For alpine, this means a
python3 binary. Therefore, we symlink /usr/bin/python3 to
/usr/bin/python.

We should really regenerate the configs, run migrations and hooks during
each container startup. Otherwise you really can't update anything at
all.

The only thing that we do not do multiple times is adding the admin
user, but the add_user method already checks for that and simply
displayed an error. Hiding that error is probably not worth the effort
so we just add a quick explanatory comment before the potential error.
Signed-off-by: Florian Pritz <bluewind@xinu.at>

The following error was shown during initial startup of the container
and the database was obviously not initialized because of this. I'm not
sure why it happens, but setting the database name in the config (in
addition to the name in the PDO connection string) fixes the problem.

> Database error: A Database Error Occurred
>
>    Error Number: 42000/1102
>    Incorrect database name ''
>    SHOW TABLES FROM ``
>    Filename: libraries/Migration.php
>    Line Number: 167
Signed-off-by: Florian Pritz <bluewind@xinu.at>

Signed-off-by: Florian Pritz <bluewind@xinu.at>

The default value has been changed to `from-image` and at least with
Firefox 76 and Chromium 83 this leads to double rotated images.
Disabling the automatic rotation with `image-orientation: none` in CSS
leads to incorrectly scaled images, (likely, but unverified) because the
width/height are returned incorrectly/rotated in jquery/javascript.
Whatever it may be, the easier fix is to just check for the new default
value and if the browser handles orientation automatically, we disable
our own code.

https://github.com/w3c/csswg-drafts/issues/3799

Signed-off-by: Florian Pritz <bluewind@xinu.at>

Signed-off-by: Florian Pritz <bluewind@xinu.at>

Signed-off-by: Florian Pritz <bluewind@xinu.at>

Signed-off-by: Florian Pritz <bluewind@xinu.at>

That way they get the correct HTTP status code and they also get ignored
by the logging code.
Signed-off-by: Florian Pritz <bluewind@xinu.at>

These are errors that a user can correct themselves so we should
classify them accordingly. That way they get the correct HTTP status
code and they also get ignored by the logging code.
Signed-off-by: Florian Pritz <bluewind@xinu.at>

These return a 500 HTTP error code and when using a CLI download tool,
you might not see the returned HTML error message. To make debugging
easier we also log them to the error log.

Some extending exceptions also return different error codes (e.g.
UserInputException) so we filter these by only logging if the return
code is 500. If a user/admin sees that code they likely expect a log
entry.
Signed-off-by: Florian Pritz <bluewind@xinu.at>

We shouldn't treat a possibly boolean value as an array
(`$filedata["data_id"]`).
Signed-off-by: Florian Pritz <bluewind@xinu.at>

Signed-off-by: Florian Pritz <bluewind@xinu.at>

Signed-off-by: Florian Pritz <bluewind@xinu.at>

Not sure why, but this only started to happen with php 7.4. Should be
fixed anyways so I didn't investigate further.
Signed-off-by: Florian Pritz <bluewind@xinu.at>

Signed-off-by: Florian Pritz <bluewind@xinu.at>

This leads to a deprecation warning as of php 7.4.
Signed-off-by: Florian Pritz <bluewind@xinu.at>

Signed-off-by: Florian Pritz <bluewind@xinu.at>

PDF thumbnail support has been removed by
98f7c65d

, but this has been left. The
thumbnails are not generated so the images show up empty. Fix it by
simply not listing them in the first place.
Signed-off-by: Florian Pritz <bluewind@xinu.at>

Signed-off-by: Florian Pritz <bluewind@xinu.at>

[ci skip] Update Cache library Redis driver to work with phpRedis 5, similarly to PR #5816 (also add changelog entry)

Fixed HTML type attribute for input field in tutorial

Update typography.rst

Adapt to new version of php-redis

Alter php5_validate_id()

Fix .aac file mime type

Correct / Added characters